Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior

Hi Fabio,

On Mon, Feb 15, 2016 at 06:54:29PM -0200, Fabio Estevam wrote:

On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber
[off-list ref] wrote:

quoted

+static int marvell_config_init(struct phy_device *phydev)
+{
+       int err;
+
+       /* Set registers from marvell,reg-init DT property */
+       err = marvell_of_reg_init(phydev);
+       if (err < 0)
+               return err;
+
+       return 0;
 }

Couldn't this be replaced by

return marvell_of_reg_init(phydev); ?

I wanted to add some missing errata fixes from the Marvell Release Notes
into that function (in the near future).
But you are right, I should probably not change things preemptively.

I'll send a v3 with that part replaced!

Thanks,
Clemens