Thread (8 messages) flat view 8 messages, 2 authors, 2016-02-13

Re: [PATCH RFC 1/3] net: bridge: log state when setting it

From: Vivien Didelot <hidden>
Date: 2016-02-13 21:49:50
Also in: lkml

Hi Ido,

Ido Schimmel [off-list ref] writes:
Fri, Feb 12, 2016 at 11:34:18PM IST, vivien.didelot@savoirfairelinux.com wrote:

Hi Vivien,
quoted
Every call to br_set_state is followed by a call to br_log_state.
Directly call it within br_set_state instead.

Signed-off-by: Vivien Didelot <redacted>
---
Maybe I'm missing something, but there are other instances of this
pattern throughout the code, so why not convert them as well? See
br_set_port_state() for example.
Good catch, I'll factorize that and send this as a unique patch then.

Thanks,
-v
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help