Re: [PATCH 8/9] rfkill: Userspace control for airplane mode
From: Dan Williams <hidden>
Date: 2016-02-10 16:53:34
Also in:
linux-api, linux-wireless, lkml, platform-driver-x86
On Wed, 2016-02-10 at 17:07 +0100, Johannes Berg wrote:
On Mon, 2016-02-08 at 10:11 -0600, Dan Williams wrote:quoted
I'd like to clarify a bit, so tell me if I'm correct or not. Using RFKILL_OP_AIRPLANE_MODE_CHANGE does not actually change any device state. It's just an indicator with no relationship to any of the registered rfkill switches, right?Yes. I'm not sure I'm totally happy with this userspace API.quoted
I wonder if setting RFKILL_OP_AIRPLANE_MODE_CHANGE(true) shouldn't also softblock all switches, otherwise you can set airplane mode all day long with RFKILL_OP_AIRPLANE_MODE_CHANGE and it doesn't actually enable airplane mode at all?No, this is kinda the point that you could implement your policy in userspace now.
Yeah, I get that now. It's just that to me, something called "AIRPLANE_MODE_CHANGE" seems like it should actually change airplane mode on/off, which implies killing radios. I wouldn't have had the problem if it was named AIRPLANE_MODE_INDICATOR_CHANGE, which makes it clear this is simply an indicator and has no actual effect on anything other than a LED. Dan