Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource

Sergei Shtylyov [off-list ref] writes:

quoted

Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse

   Fixes: tag here?

Heuh no. It doesn't fix this commit, it uses a feature brought by this commit.

quoted

+	if (irq_get_trigger_type(dev->irq) == IRQF_TRIGGER_NONE)
  		dev_warn(db->dev, "WARNING: no IRQ resource flags set.\n");

  	irqflags |= IRQF_SHARED;

   Why not just initialize to IRQF_SHARED?
   But actually you don't need this variable anymore.

Yeah, makes sense.

Cheers.

-- 
Robert