Re: [PATCH 1/3] ifb: make device count build-time configurable

On Tue, 2016-01-12 at 15:54 -0500, David Miller wrote:

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 12 Jan 2016 10:44:37 -0800

quoted

On Tue, 12 Jan 2016 07:55:22 -0500
Jamal Hadi Salim [off-list ref] wrote:

quoted

On 16-01-12 06:56 AM, Lubomir Rintel wrote:

quoted

The devices can be created at run-time for quite some time

already and the

quoted

quoted

quoted

load-time device creation collides with attempts to create the

device of

quoted

quoted

quoted

the same name:

   # rmmod ifb
   # ip link add ifb0 type ifb
   RTNETLINK answers: File exists

This is pretty much the same situation as was with the block

loop devices

quoted

quoted

quoted

which was solved by adding a build-time configuration that the
distributions could use as they deem fit while keeping the

default for

quoted

quoted

quoted

compatibility.

Let's do that here as well.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

I guess module options are frowned upon. so:

I would prefer that this were done with a module parameter, the

same as dummy.

quoted

Only developers build their own configured kernels. Having the

value set later

quoted

at module load time is preferable.

I like this even less, it means tools behave significantly
differently
based upon what module options were passed to the kernel.

Module options really should not change kernel behavior like this..

The module option is already there. It's defaults (creating the devices
noone asked for and that potentially collide with what the user tried
to create) are what we find bothersome.

Lubo