Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

On Thu, Feb 4, 2016 at 3:00 PM, Andy Shevchenko
[off-list ref] wrote:

On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook [off-list ref] wrote:

quoted

Add support for "on" and "off" when converting to boolean.

Signed-off-by: Kees Cook <redacted>
---
 lib/kstrtox.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/lib/kstrtox.c b/lib/kstrtox.c
index e18f088704d7..09e83a19a96d 100644
--- a/lib/kstrtox.c
+++ b/lib/kstrtox.c

@@ -347,6 +347,20 @@ int kstrtobool(const char *s, unsigned int base, bool *res)

Forgot update description?

Argh, thank you. Good eye. Sent another update.

-Kees

quoted

        case '0':
                *res = false;
                return 0;
+       case 'o':
+       case 'O':
+               switch (s[1]) {
+               case 'n':
+               case 'N':
+                       *res = true;
+                       return 0;
+               case 'f':
+               case 'F':
+                       *res = false;
+                       return 0;
+               default:
+                       break;
+               }
        default:
                break;
        }
--
2.6.3

--
With Best Regards,
Andy Shevchenko

-- 
Kees Cook
Chrome OS & Brillo Security