Re: [V9fs-developer] [PATCH] net/9p: convert to new CQ API
From: Dominique Martinet <asmadeus@codewreck.org>
Date: 2016-02-27 15:59:54
Also in:
linux-rdma
From: Dominique Martinet <asmadeus@codewreck.org>
Date: 2016-02-27 15:59:54
Also in:
linux-rdma
Hi, Couple of checkpatch complains: Christoph Hellwig wrote on Sat, Feb 27, 2016:
-struct p9_rdma_context {
- enum ib_wc_opcode wc_op;
+struct p9_rdma_context { trailing tab
- p9_debug(P9_DEBUG_ERROR, "req %p err %d status %d\n", req, err, status); + p9_debug(P9_DEBUG_ERROR, "req %p err %d status %d\n", req, err, wc->status);
line over 80 chars That aside it looks good ; I need to check on the new API (hadn't noticed the change) but it looks nice. Will do the actual testing likely only next week only though; Eric has been taking my patches for 9p/RDMA so I suspect he'll take your's as well eventually (get_maintainer.pl has a long-ish list of CC for us usually) BTW I think it's easy enough to do the testing if you have a server that can dish it out. diod[1] and nfs-ganesha[2] are the only two I'm aware of but there might be more (using ganesha myself; happy to help you set it up in private if you need) [1] https://github.com/chaos/diod [2] https://github.com/nfs-ganesha/nfs-ganesha -- Dominique Martinet