Thread (17 messages) flat view 17 messages, 2 authors, 2016-02-25

Re: [PATCH net-next 01/10] bnxt_en: Improve bnxt_vf_update_mac().

From: David Miller <davem@davemloft.net>
Date: 2016-02-25 17:09:23

From: Michael Chan <michael.chan@broadcom.com>
Date: Thu, 25 Feb 2016 08:57:01 -0800
We are not registering an invalid MAC address.  We are just storing it in the
driver's VF data structure.  There are 2 cases:

1. VF comes up and the MAC address from firmware is 0.  The VF will
generate random MAC.  The stored MAC address in the VF datastructure is
0 so that ip set link eth0 address is allowed on the VF.
Who looks at this 0 MAC address in the "VF datastructure", the driver?

Why does there need to be a 0 MAC address there to allow
->ndo_set_mac_address() to succeed on the VF at all?

This MAC address management between VFs and PFs looks unnecessarily
convoluted and complicated.  I'd hate to have to actually be a user
configuring this stuff.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help