Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

On Wed, Feb 24, 2016 at 5:19 AM, Jamal Hadi Salim [off-list ref] wrote:

On 16-02-23 05:23 PM, Cong Wang wrote:

quoted

On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim [off-list ref]
wrote:

quoted

quoted

It doesnt seem neccessary to have hinfo in tc_action. Quick scan:
__tcf_hash_release() seems to be the only other place that uses it.
And the callers to that appear capable of passing the struct
net or tn  which eventually propagates up...

The tcf_action_destroy() callchain still can't find out hinfo yet.

Did you mean something else or am i missing the obvious?
I am looking at the call sites for tcf_action_destroy():
-tc_dump_tfilter() has access to *net
-tcf_exts_change() - one level lower it has access to *net; i think you
added this to your patch too.
-tcf_action_init() has *net.

Well, having net is not enough, we still need net_id to retrieve hinfo,
and net_id is per module... So it is not easy at all.