Thread (2 messages) flat view 2 messages, 2 authors, 2016-02-22

Re: [PATCH next v4 0/3] IPvlan misc patches

From: David Miller <davem@davemloft.net>
Date: 2016-02-22 03:45:18

From: Mahesh Bandewar <redacted>
Date: Sat, 20 Feb 2016 19:31:22 -0800
From: Mahesh Bandewar <redacted>

This is a collection of unrelated patches for IPvlan driver.
a. crub_skb() changes are added to ensure that the packets hit the
NF_HOOKS in masters' ns in L3 mode.
b. u16 change is bug fix while
c. the third patch is to group tx/rx variables in single cacheline
I applied this series, but this is an extremely poor quality
submission.

You don't capitalize sentences, particularly in the Subject lines
of your patches.

Your descriptions are quite poor.  You say here that patch 'c' is
about grouping things for cache locality but that patch does a lot
of completely unrelated things too.

I really think you put very little effort into the formatting,
descriptions, grouping, and general layout of this patch series.  And
it shows.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help