Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6
From: Jesse Gross <jesse@kernel.org>
Date: 2016-02-18 15:32:03
On Thu, Feb 18, 2016 at 1:42 AM, Paolo Abeni [off-list ref] wrote:
On Wed, 2016-02-17 at 11:19 -0800, Jesse Gross wrote:quoted
On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni [off-list ref] wrote:quoted
the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be correctly controlled.") changed the default xmit checksum setting for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not set into external UDP header. This commit changes the rx checksum setting for both lwt vxlan/geneve devices created by openvswitch accordingly, so that lwt over ipv6 tunnel pairs are again able to communicate with default values. Signed-off-by: Paolo Abeni <pabeni@redhat.com>This is compat code that is being changed here. Based on the previous discussion, shouldn't these be made the default for all users?This change was initially aimed at a smaller scope: use self consistent default for ovs lwt devices/tunnel terminations. If there is agreement, I can post a separate patch changing the default rx checksum setting for plain vxlan and geneve[1] devices tunneling over ipv6.
OK. I think it's important to do the followup to keep things consistent but this is fine to start. Acked-by: Jesse Gross <jesse@kernel.org>