Re: [net-next PATCH v3 6/8] net: ixgbe: add minimal parser details for ixgbe

On 16-02-17 07:09 AM, David Miller wrote:

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Wed, 17 Feb 2016 06:06:02 -0500

quoted

On 16-02-17 12:18 AM, John Fastabend wrote:

quoted

This adds an ixgbe data structure that is used to determine what
headers:fields can be matched and in what order they are supported.

For hardware devices this can be a bit tricky because typically
only pre-programmed (firmware, ucode, rtl) parse graphs will be
supported and we don't yet have an interface to change these from
the OS. So its sort of a you get whatever your friendly vendor
provides affair at the moment.

In the future we can add the get routines and set routines to
update this data structure. One interesting thing to note here
is the data structure here identifies ethernet, ip, and tcp
fields without having to hardcode them as enumerations or use
other identifiers.

Signed-off-by: John Fastabend <redacted>

should __u32 be u32? Also at some points you seem to interchangeably
use unsigned int vs u32. I think most of unsigned ints should be u32.

Anything only kernel visible should be 'u32', whereas if the object is
exported via a uapi header file it should be '__u32'.

yep, it looks like you may have applied the series so I'll push a
fix for this and another to align the structs a bit better in cls_u32 as
well per Jamals feedback.

Thanks.