Re: [PATCH net 1/6] net/mlx4_en: Do not count dropped packets twice
From: Rick Jones <hidden>
Date: 2016-02-16 18:32:00
On 02/16/2016 07:01 AM, Or Gerlitz wrote:
quoted hunk ↗ jump to hunk
From: Amir Vadai <redacted> RdropOvflw counter was mistakenly copied into rx_missed_errors. Because of that it was counted twice for the device dropped packets accounting. Fixes: c27a02cd94d6 ('mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC') Signed-off-by: Amir Vadai <redacted> Signed-off-by: Eugenia Emantayev <redacted> Signed-off-by: Or Gerlitz <redacted> --- drivers/net/ethernet/mellanox/mlx4/en_port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/mellanox/mlx4/en_port.c b/drivers/net/ethernet/mellanox/mlx4/en_port.c index ee99e67..7b511a5 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_port.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_port.c@@ -242,7 +242,7 @@ int mlx4_en_DUMP_ETH_STATS(struct mlx4_en_dev *mdev, u8 port, u8 reset) stats->rx_crc_errors = be32_to_cpu(mlx4_en_stats->RCRC); stats->rx_frame_errors = 0; stats->rx_fifo_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw); - stats->rx_missed_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw); + stats->rx_missed_errors = 0; stats->tx_aborted_errors = 0; stats->tx_carrier_errors = 0; stats->tx_fifo_errors = 0;
I'm still not clear on when an Acked-by is appropriate, but given that
this has been a non-trivial frustration for a long time, a hearty
endorsement from me. Perhaps not important enough but it would be nice
to have it flow back a release or two.
That said, should mlx4_en_stats->RdropOvflw still be going into both
rx_fifo_errors and rx_over_errors?
stats->rx_over_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw);
stats->rx_crc_errors = be32_to_cpu(mlx4_en_stats->RCRC);
stats->rx_frame_errors = 0;
stats->rx_fifo_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw);
happy benchmarking,
rick jones