Thread (7 messages) flat view 7 messages, 2 authors, 2016-02-08

Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels

From: Jakub Kicinski <hidden>
Date: 2016-02-08 13:33:16

Hi Jacob!

First of all thanks for putting your time into sorting this out,
figuring out what to do with user-set RSS table when queues are
reconfigured was a head scratcher for me as well.

On Fri,  5 Feb 2016 12:30:21 -0800, Jacob Keller wrote:
+#define FM10K_FLAG_RETA_TABLE_CONFIGURED	(u32)(BIT(6))
If we go with your proposal every driver will have to keep track of 
how the RSS table was set and find max value on queue reconfig -
replicating effort and leaving space for diverging behaviour...

Would it be worth considering to place more of this code in the core?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help