Thread (13 messages) 13 messages, 6 authors, 2016-07-29

RE: [PATCH net-next 1/2] mpls: packet stats

From: David Laight <hidden>
Date: 2016-02-08 11:54:15

From: Francois Romieu
Sent: 06 February 2016 10:59
quoted
+void mpls_stats_inc_outucastpkts(struct net_device *dev,
+				 const struct sk_buff *skb)
+{
+	struct mpls_dev *mdev;
+	struct inet6_dev *in6dev;
Nit: the scope can be reduced for both variables.
And hiding the definitions of variables in the middle of
functions just makes them harder to find.	

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help