Re: [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support

On 02/07/2016 08:31 PM, David Miller wrote:

From: Nikolay Aleksandrov <razor@blackwall.org>
Date: Wed,  3 Feb 2016 04:04:35 +0100

quoted

Patch 1 adds ethtool speed/duplex validation functions which check if the
value is defined. Patch 2 adds support for ethtool (get|set)_settings and
uses the validation functions to check the user-supplied values.

v2: split in 2 patches to allow everyone to make use of the validation
functions and allow virtio_net devices to be half duplex
v3: added a check to return error if the user tries to change anything else
besides duplex/speed as per Michael's comment
v4: Set port type to PORT_OTHER
v5: clear diff1.port (ignore port) when checking for changes since we set
it now and ethtool uses it in the set request

Sorry about the pointless iterations, should've all covered now.

Series applied, thanks Nik.

Thank you Dave, I was actually waiting for Michael's ethtool patch to go in.
I'll send a follow-up to make sure the port is what we set it to and also
to allow setting any speed (as people commented, devices can have any speed
these days, so we don't want to limit them to the defined ones).