Thread (3 messages) flat view 3 messages, 3 authors, 2016-02-08

Re: [PATCH next 2/3] ipvlan: mode is u16

From: David Miller <davem@davemloft.net>
Date: 2016-02-07 19:19:14

From: Mahesh Bandewar <redacted>
Date: Tue,  2 Feb 2016 11:20:30 -0800
From: Mahesh Bandewar <redacted>

The mode argument was erronusly defined as u32 but it has always
been u16.

Signed-off-by: Mahesh Bandewar <redacted>
This patch is changing more than this.

Specifically it is invoking ipvlan_set_port_mode() instead of assigning
port->mode directly in ipvlan_link_new().

That minimally needs to be documented in the commit log message.

But I also wonder if for some reason in this conect the direct
assignment happens to be fine.  That's pretty much why you should
explain things.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help