Re: [PATCH net-next v1 06/10] tipc: fix connection abort when receiving invalid cancel request

Hello.

On 2/1/2016 12:44 PM, Parthasarathy Bhuvaragan wrote:

Until now, the subscribers endianness for a subscription
create/cancel request is determined as:
     swap = !(s->filter & (TIPC_SUB_PORTS | TIPC_SUB_SERVICE))
The checks are performed only for port/service subscriptions.

The swap calculation is incorrectly if the filter in the subscription

    Incorrect.

cancellation request is set to TIPC_SUB_CANCEL (its a malformed

    It's.

cancel request, as the corresponding subscription create filter
is missing).
Thus, the check if the request is for cancellation fails and the
request is treated as a subscription create request. The
subscription creation fails as the request is illegal, which
terminates this connection.

In this commit we determine the endianness by including
TIPC_SUB_CANCEL, which will set swap correctly and the
request is processed as a cancel request.

    Cancellation, maybe, as it was worded above?

Acked-by: Ying Xue <redacted>
Reviewed-by: Jon Maloy <redacted>
Signed-off-by: Parthasarathy Bhuvaragan <redacted>

[...]

MBR, Sergei