Thread (13 messages) 13 messages, 7 authors, 2016-02-01

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

From: Lucas Tanure <hidden>
Date: 2016-01-30 14:05:55
Also in: lkml

On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy [off-list ref] wrote:
On 30.01, Lucas Tanure wrote:
quoted
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'uX' over 'uintX_t'
You might have noticed we have literally hundreds of them spread over 100
files in the netfilter code. We'll gradually change them when the code is
touched anyways.
quoted
 net/ipv4/netfilter/ip_tables.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Yes, I checked that. But would be better to change that now?
Because:
- could take years to anyone to touch the code, as the code already
works very well
- be more standardized could facilitate reading the code
- It's a good way to encourage new people to contribute to the code

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help