Re: [PATCH net 5/6] net: mvneta: The mvneta_percpu_elect function should be atomic
From: David Miller <davem@davemloft.net>
Date: 2016-01-30 04:38:15
Also in:
linux-arm-kernel, lkml
From: Gregory CLEMENT <redacted> Date: Fri, 29 Jan 2016 17:26:06 +0100
quoted hunk ↗ jump to hunk
@@ -370,6 +370,8 @@ struct mvneta_port { struct net_device *dev; struct notifier_block cpu_notifier; int rxq_def; + /* protect */ + spinlock_t lock; /* Core clock */ struct clk *clk;
Protect what? This comment needs a lot of improvement. Everyone knows a spinlock "protects" things, so if you aren't going to actually describe what this lock protects, and in what contexts the lock is used, you might as well not say anything at all.