Re: [PATCH] sfc: Replace memset with eth_zero_addr

Hi,

On Wed, Jan 20, 2016 at 9:44 AM, Sergei Shtylyov
[off-list ref] wrote:

Hello.

On 1/20/2016 2:27 AM, Lucas Tanure wrote:

quoted

Use eth_zero_addr to assign the zero address to the given address array
instead of memset when second argument is address of zero.

   What address? memset() takes just 1 address. :-)

I mean the vf->mac, a pointer to a six-byte array containing the
Ethernet address.

quoted

Signed-off-by: Lucas Tanure <redacted>
---
  drivers/net/ethernet/sfc/ef10_sriov.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c

b/drivers/net/ethernet/sfc/ef10_sriov.c
index 3c17f27..10f60db 100644

--- a/drivers/net/ethernet/sfc/ef10_sriov.c
+++ b/drivers/net/ethernet/sfc/ef10_sriov.c

@@ -527,7 +527,7 @@ int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int

vf_i, u8 *mac)
        return 0;

  fail:
-       memset(vf->mac, 0, ETH_ALEN);
+       eth_zero_addr(vf->mac);
        return rc;
  }

MBR, Sergei

Thanks, Tanure