Re: [PATCH 4/4] net: mvneta: update clocks property and document additional clock-names
From: Thomas Petazzoni <hidden>
Date: 2016-01-20 09:09:50
Also in:
linux-arm-kernel, linux-devicetree, lkml
Dear Jisheng Zhang, On Wed, 20 Jan 2016 16:06:23 +0800, Jisheng Zhang wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt index aeea50c..f85b93b 100644 --- a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt +++ b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt@@ -6,12 +6,16 @@ Required properties: - interrupts: interrupt for the device - phy: See ethernet.txt file in the same directory. - phy-mode: See ethernet.txt file in the same directory -- clocks: a pointer to the reference clock for this device. +- clocks: Array of clocks required for this device; requires at least one + for CORE clock.
Rather than "Array", I would say "list", so what about: - clocks: List of clocks for this device. At least one clock is mandatory for the core clock. If several clocks are given, then the clock-names property must be used to identify them.
Optional properties: - tx-csum-limit: maximum mtu supported by port that allow TX checksum. Value is presented in bytes. If not used, by default 1600B is set for "marvell,armada-370-neta" and 9800B for others. +- clock-names: Array of names corresponding to clocks property; shall be + "core" for CORE clock and "axi" for optional AXI clock.
Array -> List. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com