Re: [PATCH] net: phy: smsc: Fix disabling energy detect mode
From: David Miller <davem@davemloft.net>
Date: 2016-01-15 19:55:07
Also in:
lkml
From: Teresa Remmet <redacted> Date: Fri, 15 Jan 2016 10:20:33 +0100
quoted hunk ↗ jump to hunk
@@ -110,10 +105,11 @@ static int lan911x_config_init(struct phy_device *phydev) */ static int lan87xx_read_status(struct phy_device *phydev) { + bool *energy_enable = phydev->priv; int err = genphy_read_status(phydev); int i;
Please order local variable declarations from longest to shortest line.
+static int smsc_phy_probe(struct phy_device *phydev)
+{
+ struct device *dev = &phydev->mdio.dev;
+ bool *energy_enable;
+ int __maybe_unused len;
+ struct device_node *of_node __maybe_unused = dev->of_node;Likewise.