Thread (2 messages) flat view 2 messages, 2 authors, 2016-01-12

Re: [PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

From: Michael Büsch <m@bues.ch>
Date: 2016-01-12 05:45:20
Also in: linux-wireless, lkml

On Tue, 12 Jan 2016 09:01:04 +0800
Jia-Ju Bai [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The memory allocated by kzalloc in b43_bus_dev_ssb_init and
b43_bus_dev_bcma_initis not freed.
This patch fixes the bug by adding kfree in b43_ssb_remove,
b43_bcma_remove and error handling code of b43_bcma_probe.

Thanks Michael for his suggestion.

Signed-off-by: Jia-Ju Bai <redacted>
---
 drivers/net/wireless/b43/main.c |    3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index ec013fb..2c9d9c1 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5683,6 +5683,7 @@ static int b43_bcma_probe(struct bcma_device *core)
 	schedule_work(&wl->firmware_load);
 
 bcma_out:
+	kfree(dev);
 	return err;
 
This is not correct. It will also free dev for the non-error exit.


-- 
Michael

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help