Thread (13 messages) flat view 13 messages, 3 authors, 2016-01-11

Re: [PATCH v4.4-rc8 6/7] isdn: eicon: diddfunc: Silence frame size warning

From: Sergei Shtylyov <hidden>
Date: 2016-01-08 20:04:17
Also in: lkml

Hello.

On 01/08/2016 03:32 PM, tim.gardner@canonical.com wrote:
quoted hunk ↗ jump to hunk
From: Tim Gardner <redacted>

drivers/isdn/hardware/eicon/diddfunc.c: In function 'connect_didd':
drivers/isdn/hardware/eicon/diddfunc.c:77:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=]

gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1)

Cc: Armin Schindler <redacted>
Cc: Karsten Keil <redacted>
Signed-off-by: Tim Gardner <redacted>
---
  drivers/isdn/hardware/eicon/diddfunc.c | 17 +++++++++++++----
  1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/isdn/hardware/eicon/diddfunc.c b/drivers/isdn/hardware/eicon/diddfunc.c
index b0b23ed..a9feb4f 100644
--- a/drivers/isdn/hardware/eicon/diddfunc.c
+++ b/drivers/isdn/hardware/eicon/diddfunc.c
@@ -52,9 +52,13 @@ static int __init connect_didd(void)
  	int x = 0;
  	int dadapter = 0;
  	IDI_SYNC_REQ req;
-	DESCRIPTOR DIDD_Table[MAX_DESCRIPTORS];
+	DESCRIPTOR *DIDD_Table;

-	DIVA_DIDD_Read(DIDD_Table, sizeof(DIDD_Table));
+	DIDD_Table = kcalloc(MAX_DESCRIPTORS, sizeof(*DIDD_Table), GFP_KERNEL);
   Previously the array didn't seem to be zeroed, perhaps it's better to use 
kmalloc_array()?

[...]

MHR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help