Thread (10 messages) 10 messages, 3 authors, 2016-01-07

Re: net-thunder: One check less in nicvf_register_interrupts() after error detection

flat view

From: Joe Perches <joe@perches.com>
Date: 2016-01-07 20:28:55
Also in: kernel-janitors, linux-arm-kernel, lkml

On Thu, 2016-01-07 at 21:07 +0100, SF Markus Elfring wrote:
quoted
quoted
* Which object code representations would you find representative
  for a further constructive discussion around this
  software component?
Evidence of actual object code improvement
How do you think about to provide a function implementation
which looks a bit more efficient by default?
It's not a matter of "looks a bit more efficient".
it's taste, style, and repetition for various functions.

Some prefer that source code be "templatized" regardless
of the number of exit points that any particular use of a
specific function type.

Some of your patches are converting these templatized
functions to a different form for no added value.

These patches make the local source code inconsistent
and generally goes against the authors preferred style.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help