Re: [PATCH 2/3] net-iwlegacy: One check less in il_eeprom_init() after error detection
From: Sergei Shtylyov <hidden>
Date: 2016-01-01 23:13:15
Also in:
kernel-janitors, linux-wireless, lkml
Hello. On 1/1/2016 11:31 PM, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Fri, 1 Jan 2016 21:12:29 +0100 This issue was detected by using the Coccinelle software. Adjust a jump target to avoid a check repetition before the function call "il_eeprom_free".
One question: why?
quoted hunk ↗ jump to hunk
Signed-off-by: Markus Elfring <redacted> --- drivers/net/wireless/intel/iwlegacy/common.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)diff --git a/drivers/net/wireless/intel/iwlegacy/common.c b/drivers/net/wireless/intel/iwlegacy/common.c index c3afaf7..ae45fd3 100644 --- a/drivers/net/wireless/intel/iwlegacy/common.c +++ b/drivers/net/wireless/intel/iwlegacy/common.c
[...]
quoted hunk ↗ jump to hunk
@@ -772,9 +772,11 @@ il_eeprom_init(struct il_priv *il) done: il->ops->eeprom_release_semaphore(il); -err: - if (ret) + if (ret) { +free_eeprom:
This is ugly, I'd say.
[...]
MBR, Sergei