Thread (52 messages) 52 messages, 6 authors, 2016-01-29

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

From: zhuyj <zyjzyj2000@gmail.com>
Date: 2016-01-29 07:05:31

Thanks a lot.

Maybe this patch is to miimon and notifier. Maybe it is not appropriate to arp monitor.
So the following patch will avoid arp monitor.

Thanks a lot.

Zhu Yanjun

+	/* Because of link flap from the slave interface, it is possilbe that
+	 * the notifiler is NETDEV_UP while the actual link state is down. If
+	 * so, it is not necessary to contiune.
+	 */
+	if (!bond->params.arp_interval) {
+		switch (event) {
+		case NETDEV_UP:
+			if (!link_state)
+				return 0;
+			break;
+
+		case NETDEV_DOWN:
+			if (link_state)
+				return 0;
+			break;
+		}
+	}


On 01/26/2016 02:00 PM, Jay Vosburgh wrote:
+	/* Because of link flap from the slave interface, it is possilbe that
+	 * the notifiler is NETDEV_UP while the actual link state is down. If
+	 * so, it is not necessary to contiune.
+	 */
+	switch (event) {
+	case NETDEV_UP:
+		if (!link_state)
+			return 0;
+		break;
+
+	case NETDEV_DOWN:
+		if (link_state)
+			return 0;
+		break;
+	}
+
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help