Re: [PATCH] igb: Fix VLAN tag stripping on Intel i350

Hi Jeff,

On Jan 27 11:25, Jeff Kirsher wrote:

On Wed, 2016-01-27 at 14:28 +0100, Corinna Vinschen wrote:

quoted

Problem: When switching off VLAN offloading on an i350, the VLAN
interface gets unusable.  For testing, set up a VLAN on an i350
and some remote machine, e.g.:
[...]

I tried applying your patch to my tree for review and validation, but
due to patches already applied against the igb driver in my tree, your
patch does not apply cleanly.

Can you please update your patch to apply cleanly to my tree?
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue

(next-queue tree and dev-queue branch)

The attached patch is against the dev-queue branch of your next-queue tree.

I retested again using an i350 as well as a 82580.  On the i350 I tested
additionally adding and removing VFs while offloading was switched on or
off, and it worked as desired.

I'm just a bit unsure about the correctness of the igb_set_vf_vlan_strip
call from igb_vf_reset.  I think it's the right thing to do since
resetting the VF requires to reevaluate the STRVLAN flag.  I'd feel
better if you could double check, though.


Thanks,
Corinna