Re: [PATCH] net: dsa: fix mv88e6xxx switches

On Sat, Jan 23, 2016 at 11:12:32PM +0100, Andrew Lunn wrote:

quoted

This shows port 0 is on vlan 0, but it should default to vlan 1 when
no vlans are configured.  The patch below should at least allow some
diagnosis of what's being requested, and when.

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index a43354ed0607..8a9cf67eb16d 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c

@@ -1511,6 +1511,9 @@ int mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,
 	u16 vid;
 	int err = 0;
 
+	printk("%s: port %d vid %u-%u flags %x\n",
+		__func__, port, vlan->vid_begin, vlan->vid_end, vlan->flags);
+

Hi Russell

Never called.

So i guess we have a kernel configuration difference.

I don't have CONFIG_BRIDGE_VLAN_FILTERING.

Yep, confirmed. When i enable this option, and VLAN_8021Q which it
depends on, i then have a working bridge.

	Andrew