RE: [PATCH V2 5/5] i40e/ethtool: support coalesce setting by queue

From: Liang, Kan

quoted

This looks reasonable, but be aware that since there's no concept of
queue-specific settings in the driver proper, these settings will get

lost on

quoted

the next reset - see i40e_vsi_configure_msix().  A reset can be driven

by a

quoted

number of things such as MTU changes, LLDP events, tx timeout recovery,
promiscuous on/off, and various other configuration changes.  This might
not be acceptable for your needs.

Yes, the reset could be an issue.
I guess we may make the concept of queue-specific settings for i40e by
moving
rx_itr_setting and tx_itr_setting to i40e_ring.

How about the patch as below?
The patch only move itr_setting from i40e_vsi to i40e_ring.
There should be no behavior change.

Thanks, I finally had a chance to look through this.  On an initial read-through, yes, this would probably take care of it.

sln