Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-01-11 09:32:15
Also in:
linux-sctp
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-01-11 09:32:15
Also in:
linux-sctp
David Miller [off-list ref] wrote:
From: Eric Dumazet <redacted> Date: Wed, 30 Dec 2015 11:57:31 -0500quoted
I am against using rhashtable in SCTP (or TCP) at this stage, given the number of bugs we have with it.Come on Eric, we've largely dealt with all of these problems. I haven't seen a serious report in a while.
Well there is still the outstanding issue with softirq insertion potentially failing with ENOMEM if we fail to expand the hash table using just kmalloc. So if the target user does softirq insertions, I would wait until the fix for that is ready. Thanks, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt