Thread (19 messages) flat view 19 messages, 5 authors, 2016-01-11

Re: [PATCH net-next v4 05/10] fm10k: add rtnl lock protection in fm10k_io_resume

From: Hannes Frederic Sowa <hidden>
Date: 2016-01-09 22:44:21

On 09.01.2016 22:51, Florian Westphal wrote:
Hannes Frederic Sowa [off-list ref] wrote:
quoted
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index 4eb7a6fa6b0ddc..846d9b731c8c14 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
@@ -2350,8 +2350,10 @@ static void fm10k_io_resume(struct pci_dev *pdev)
  	/* reset clock */
  	fm10k_ts_reset(interface);

+	rtnl_lock();
  	if (netif_running(netdev))
  		err = fm10k_open(netdev);
+	rtnl_lock();
Hmm.  Looks like copy&paste error :)
Oh, yeah. Thanks, Florian, fixed it up locally.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help