Re: [PATCH net-next v3 8/8] geneve: break dependency to network drivers

On 07.01.2016 01:18, Jesse Gross wrote:

I think we should merge vxlan_get_rx_port() and geneve_get_rx_port()
into a single generic function. For drivers that support both, they
now have two calls to get notified for all offloaded ports. This
actually can cause problems related to duplicates, similar to what you
feared before.

Checking out the ndo_add_vxlan_port callbacks, we cannot change how we 
refresh the ports unfortunately. For some drivers it might be easy to 
update, some look a little bit more complicated.

I guess we should try to keep more complexity in the core and make sure 
we only call those functions if necessary for the particular type of 
offload than to replicate the logic in each driver.

If you agree I prepare this series with the changes to have separate 
callbacks, address your other feedback and send it out.

Thanks,
Hannes