Re: [PATCHv2 net-next 0/4] MTU changes and other fixes

From: Jakub Kicinski <redacted>
Date: Thu, 7 Jan 2016 20:49:28 +0000

I know this is not what you asked for but, since we are using FW
commands to disable/enable RX, even if we allocate all required
resources before freeing old ones we still cannot guarantee that
the reenabling operation will not fail.  Should we refuse to do
MTU changes while the interface is running altogether?

If you issue the MTU change command and it fails, then you're still
configured at the old MTU.  There should therefore be no problem
rewinding in that case.

All drivers I've seen ...

Bad practice in other drivers should be ignored, not copied.