Thread (5 messages) 5 messages, 2 authors, 2015-12-28
STALE3821d
Revisions (3)
  1. v1 [diff vs current]
  2. v1 current
  3. v2 [diff vs current]

[PATCH v1 0/3] bpf: hash: use per-bucket spinlock

From: Ming Lei <tom.leiming@gmail.com>
Date: 2015-12-28 12:56:12
Also in: lkml

Hi,

This patchset tries to optimize ebpf hash map, and follows
the idea:

	Both htab_map_update_elem() and htab_map_delete_elem()
	can be called from eBPF program, and they may be in kernel
	hot path, it isn't efficient to use a per-hashtable lock
	in this two helpers, so this patch converts the lock into
	per-bucket spinlock.

With this patchset, looks the performance penalty from eBPF
decreased a lot, see the following test:

	1) run 'tools/biolatency' of bcc before running block test;

	2) run fio to test block throught over /dev/nullb0,
	(randread, 16jobs, libaio, 4k bs) and the test box
	is one 24cores(dual sockets) VM server:
	- without patchset:  607K IOPS
	- with this patchset: 1184K IOPS
	- without running eBPF prog: 1492K IOPS

TODO:
	- remove the per-hashtable atomic counter

V1:
	- fix the wrong 3/3 patch 


 kernel/bpf/hashtab.c | 60 +++++++++++++++++++++++++++++++---------------------
 1 file changed, 36 insertions(+), 24 deletions(-)

Thanks,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help