Thread (11 messages) flat view 11 messages, 4 authors, 2015-12-08

Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage

From: Joe Perches <joe@perches.com>
Date: 2015-12-07 03:32:08
Also in: lkml

On Sun, 2015-12-06 at 22:29 -0500, David Miller wrote:
From: yankejian <redacted>
Date: Sat, 5 Dec 2015 15:32:29 +0800
quoted
+#if (PAGE_SIZE < 8192)
+     if (hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048) {
+             truesize = hnae_buf_size(ring);
+     } else {
+             truesize = ALIGN(size, L1_CACHE_BYTES);
+             last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
+     }
+
+#else
+             truesize = ALIGN(size, L1_CACHE_BYTES);
+             last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
+#endif
This is not indented properly, and it looks terrible.
And it makes one curious as to why last_offset isn't set
in the first block.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help