[PATCH] brcm80211: fix compare_const_fl.cocci warnings
From: Julia Lawall <hidden>
Date: 2015-12-06 06:03:29
Also in:
linux-wireless, lkml
Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci Signed-off-by: Fengguang Wu <redacted> Signed-off-by: Julia Lawall <redacted> --- Minor point. But in my opinion, it would look a little nicer to have the thing acted on (code[...]) come first. channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/channel.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/channel.c@@ -177,8 +177,8 @@ static bool brcms_c_country_valid(const * only allow ascii alpha uppercase for the first 2 * chars. */ - if (!((0x80 & ccode[0]) == 0 && ccode[0] >= 0x41 && ccode[0] <= 0x5A && - (0x80 & ccode[1]) == 0 && ccode[1] >= 0x41 && ccode[1] <= 0x5A)) + if (!((ccode[0] & 0x80) == 0 && ccode[0] >= 0x41 && ccode[0] <= 0x5A && + (ccode[1] & 0x80) == 0 && ccode[1] >= 0x41 && ccode[1] <= 0x5A)) return false; /*