Thread (5 messages) flat view 5 messages, 3 authors, 2015-12-18
STALE3902d

[PATCH iproute2] ip, route: fix minor compile warning

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2015-12-14 15:34:32
Subsystem: the rest · Maintainer: Linus Torvalds

Seems like gcc (4.8.3) doesn't catch this false positive, triggering
after 0f7543322c5f ("route: ignore RTAX_HOPLIMIT of value -1"):

  iproute.c: In function 'print_route':
  iproute.c:301:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
     features &= ~RTAX_FEATURE_ECN;
              ^
  iproute.c:575:10: note: 'val' was declared here
      __u32 val;
            ^
So just shut it up by initializing to 0.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---
 ip/iproute.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iproute.c b/ip/iproute.c
index c42ea0b..867c8da 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -572,7 +572,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
 			mxlock = *(unsigned*)RTA_DATA(mxrta[RTAX_LOCK]);
 
 		for (i=2; i<= RTAX_MAX; i++) {
-			__u32 val;
+			__u32 val = 0;
 
 			if (mxrta[i] == NULL)
 				continue;
-- 
1.9.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help