Thread (8 messages) 8 messages, 4 authors, 2015-12-08

RE: 4.4-rc2 xfrm_lookup kasan trace

From: David Laight <hidden>
Date: 2015-12-08 14:37:26

From: Of David Miller
Sent: 03 December 2015 16:59
From: Eric Dumazet <redacted>
Date: Mon, 30 Nov 2015 17:22:11 -0800
quoted
@@ -2198,6 +2198,7 @@ struct dst_entry *xfrm_lookup(struct net *net, struct dst_entry *dst_orig,
 	xdst = NULL;
 	route = NULL;

+	sk = sk_to_full_sk((struct sock *)sk);
The war against const...

I know this is the only instance where const is input, but you may want to
consider adding the const verion of the helper anyways to avoid ugly casts
like this.
In that case you could use something like:

#define SK_TO_FULL_SK(sk) (typeof (sk))sk_to_full_sk(sk))

With the helper arg and result being 'const struct sock *'.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help