Thread (10 messages) 10 messages, 4 authors, 2015-12-03

Re: [PATCH v2 net-next] tcp: suppress too verbose messages in tcp_send_ack()

From: David Miller <davem@davemloft.net>
Date: 2015-12-03 04:44:56

From: Eric Dumazet <redacted>
Date: Mon, 30 Nov 2015 08:57:28 -0800
From: Eric Dumazet <edumazet@google.com>

If tcp_send_ack() can not allocate skb, we properly handle this
and setup a timer to try later.

Use __GFP_NOWARN to avoid polluting syslog in the case host is
under memory pressure, so that pertinent messages are not lost under
a flood of useless information.

sk_gfp_atomic() can use its gfp_mask argument (all callers currently
were using GFP_ATOMIC before this patch)

We rename sk_gfp_atomic() to sk_gfp_mask() to clearly express this
function now takes into account its second argument (gfp_mask)

Note that when tcp_transmit_skb() is called with clone_it set to false,
we do not attempt memory allocations, so can pass a 0 gfp_mask, which
most compilers can emit faster than a non zero or constant value.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
v2: rename sk_gfp_atomic() to sk_gfp_mask()
Applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help