Re: [PATCH net v2] openvswitch: properly refcount vport-vxlan module
From: David Miller <davem@davemloft.net>
Date: 2015-12-01 19:26:31
From: David Miller <davem@davemloft.net>
Date: 2015-12-01 19:26:31
From: Hannes Frederic Sowa <redacted> Date: Tue, 01 Dec 2015 16:41:48 +0100
On Tue, Dec 1, 2015, at 14:19, Paolo Abeni wrote:quoted
Currently all the vport_ops list manipulation functions are protected by the ovs_lock (even the lookup): the scenario described above should not be possible.This makes all sense and it seems no use-after-free is possible at all (I didn't notice the lookup path takes the lock). But the macro still looks ugly and modifies a global struct with a per-module linked symbol. David, why exactly didn't you like the first patch? Seems to me it does what is actually needed.
Because it is error prone. I want it hidden quietly and reliably in a macro, just like we do for other similar cases across the tree. The caller of the registry functions has no reason to be concerned with these details if we can take care of it transparently.