Thread (9 messages) 9 messages, 6 authors, 2015-11-16

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

flat view

From: Ben Hutchings <hidden>
Date: 2015-11-14 17:39:40
Also in: stable

On Thu, 2015-10-15 at 14:25 +0200, Sabrina Dubroca wrote:
Without this length argument, we can read past the end of the iovec
in
memcpy_toiovec because we have no way of knowing the total length of
the
iovec's buffers.

This is needed for stable kernels where 89c22d8c3b27 ("net: Fix skb
csum races when peeking") has been backported but that don't have the
ioviter conversion, which is almost all the stable trees <= 3.18.

This also fixes a kernel crash for NFS servers when the client uses
 -onfsvers=3,proto=udp to mount the export.

Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Hannes Frederic Sowa <redacted>
---
Note: this is based on 3.14.54, as 3.18 doesn't need the hunk for
net/rxrpc/ar-recvmsg.c, but all older stable kernels do.
[...]

Queued up for 3.2, thanks.

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                           - Albert Einstein

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help