Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem
From: David Miller <hidden>
Date: 2015-11-30 19:51:04
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Salil Mehta <redacted> Date: Thu, 26 Nov 2015 07:14:06 +0000
-#define ENABLE (0x1) -#define DISABLE (0x0) +#define ENABLE 0x1 +#define DISABLE 0x0
Defining such common macros names for such incredibly simple boolean values is asking for trouble, in particular it can possibly collide with other defines in the global namespace. Use "true", "false", and the "bool" type, because that is exactly how you are using these values. Thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html