RE: [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE()
From: Grumbach, Emmanuel <hidden>
Date: 2015-11-25 13:47:49
Also in:
linux-wireless, lkml
WARN_ON_ONCE() takes a condition rather than a format string. This patch converted WARN_ON_ONCE() to WARN_ONCE() instead. Signed-off-by: Geliang Tang <redacted> --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Already fixed. Thanks.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.cb/drivers/net/wireless/intel/iwlwifi/mvm/rs.c index d1ad103..58d7bee 100644--- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c@@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm*mvm, rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 : LQ_HT_MIMO2; rate_mask = lq_sta->active_mimo2_rate; } else { - WARN_ON_ONCE("Bad column mode"); + WARN_ONCE(1, "Bad column mode"); } if (column->mode != RS_LEGACY) { -- 2.5.0