Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

From
Daniel Wagner <hidden>
Date
2015-11-23 12:43:10
Also in
cgroups, lkml, netfilter-devel
Reply to
Tejun Heo, 2015-11-21
Hi Tejun,

On 11/21/2015 05:14 PM, Tejun Heo wrote:> +static int
cgroup_mt_check_v1(const struct xt_mtchk_param *par)
+{
+	struct xt_cgroup_info_v1 *info = par->matchinfo;
+	struct cgroup *cgrp;
+
+	if ((info->invert_path & ~1) || (info->invert_classid & ~1))
+		return -EINVAL;
The checks below use pr_info() in case the configuration is not valid.
Is this missing here on purpose?

I have tested it slightly and it seems to work (also on an older
kernel). I don't know if that qualifies it for a Tested-by but at least
Acked-by should do the trick:

Tested-by: Daniel Wagner <redacted>
Acked-by: Daniel Wagner <redacted>

cheers,
daniel
Thread (37 messages) 37 messages, 8 authors, last reply 2015-11-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help