[PATCH] ixp4xx_hss: Delete an unnecessary check before the function call "dma_pool_destroy"
From: SF Markus Elfring <hidden>
Date: 2015-11-16 12:36:43
Also in:
kernel-janitors, lkml
Subsystem:
arm/intel ixp4xx arm architecture, networking drivers, the rest · Maintainers:
Linus Walleij, Imre Kaloz, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2015-11-25 · Re: [PATCH] ixp4xx_hss: Delete an unnecessary check before the function call "dma_pool_destroy" · khalasa@piap.pl (Krzysztof Hałasa)
From: Markus Elfring <redacted> Date: Mon, 16 Nov 2015 13:30:37 +0100 The dma_pool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted> --- drivers/net/wan/ixp4xx_hss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
index e7bbdb7..0d2593a 100644
--- a/drivers/net/wan/ixp4xx_hss.c
+++ b/drivers/net/wan/ixp4xx_hss.c@@ -1037,7 +1037,7 @@ static void destroy_hdlc_queues(struct port *port) port->desc_tab = NULL; } - if (!ports_open && dma_pool) { + if (!ports_open) { dma_pool_destroy(dma_pool); dma_pool = NULL; }
--
2.6.2