Re: [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label
From: Vladimir Davydov <hidden>
Date: 2015-11-14 16:33:34
Also in:
cgroups, linux-mm, lkml
From: Vladimir Davydov <hidden>
Date: 2015-11-14 16:33:34
Also in:
cgroups, linux-mm, lkml
On Thu, Nov 12, 2015 at 06:41:24PM -0500, Johannes Weiner wrote:
Move the jump-label from sock_update_memcg() and sock_release_memcg() to the callsite, and so eliminate those function calls when socket accounting is not enabled.
I don't believe this patch's necessary, because these functions aren't hot paths. Neither do I think it makes the code look better. Anyway, it's rather a matter of personal preference, and the patch looks correct to me, so Reviewed-by: Vladimir Davydov <redacted>
This also eliminates the need for dummy functions because the calls will be optimized away if the Kconfig options are not enabled. Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>