Thread (1 message) 1 message, 1 author, 2015-11-13

Re: [PATCH] net: phy: vitesse: add support for VSC8601

From: Måns Rullgård <hidden>
Date: 2015-11-13 10:06:26
Also in: lkml

Mason [off-list ref] writes:
On 12/11/2015 19:41, Mans Rullgard wrote:
quoted
+	.phy_id         = PHY_ID_VSC8601,
+	.name           = "Vitesse VSC8601",
+	.phy_id_mask    = 0x000ffff0,
+	.features       = PHY_GBIT_FEATURES,
+	.flags          = PHY_HAS_INTERRUPT,
+	.config_init    = &genphy_config_init,
+	.config_aneg    = &genphy_config_aneg,
+	.read_status    = &genphy_read_status,
+	.ack_interrupt  = &vsc824x_ack_interrupt,
+	.config_intr    = &vsc82xx_config_intr,
I expected Documentation/CodingStyle to forbid taking the address
of functions.
I can't find anything to that effect.  That said, it's not something I
would normally do, but all the other phy_driver entries in that file
look like that.

-- 
Måns Rullgård
mans@mansr.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help