Thread (6 messages) 6 messages, 2 authors, 2015-12-01

Re: [PATCH 1/2] sfc: make TSO version a per-queue parameter

From: David Miller <davem@davemloft.net>
Date: 2015-11-30 03:50:44

From: Bert Kenward <redacted>
Date: Wed, 25 Nov 2015 16:06:14 +0000
 	if (!(nic_data->datapath_caps &
-	      (1 << MC_CMD_GET_CAPABILITIES_OUT_TX_TSO_LBN))) {
-		netif_err(efx, drv, efx->net_dev,
Can you please keep code properly indented...
+
+	if (nic_data->datapath_caps &
+			(1 << MC_CMD_GET_CAPABILITIES_OUT_TX_TSO_LBN)) {
when all you are doing is moving it from one place to another?

That first parenthesis on the second line must start exactly at the
first column after the openning parenthesis of the enclosing
if () statement.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help